Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop catching panics #3777

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Stop catching panics #3777

merged 1 commit into from
Jun 6, 2024

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Jun 6, 2024 •
edited
Loading

What?

We stop catching the panic in k6.

Why?

Catching the panic could prevent us/customers from identifying them early. Instead, we should deliver the fixes for the panic cases.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Closes #3748

@olegbespalov olegbespalov added this to the v0.52.0 milestone Jun 6, 2024
@olegbespalov olegbespalov self-assigned this Jun 6, 2024
@olegbespalov olegbespalov requested a review from a team as a code owner June 6, 2024 10:40
@olegbespalov olegbespalov requested review from mstoykov and oleiade and removed request for a team June 6, 2024 10:40
mstoykov
mstoykov previously approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Have you checked if some extension doesn't use it - maybe we can tell them.

codebien
codebien previously approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We should add the breaking change label

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.77%. Comparing base (bd114fd) to head (58a51c3).

❗ Current head 58a51c3 differs from pull request most recent head 5389a22

Please upload reports for the commit 5389a22 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3777      +/-   ##
==========================================
- Coverage   70.87%   70.77%   -0.11%     
==========================================
  Files         291      289       -2     
  Lines       21227    21215      -12     
==========================================
- Hits        15044    15014      -30     
- Misses       5218     5230      +12     
- Partials      965      971       +6
Flag Coverage Δ
ubuntu 70.77% <100.00%> (-0.04%) ⬇️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

joanlopez
joanlopez previously approved these changes Jun 6, 2024
View reviewed changes
@olegbespalov olegbespalov dismissed stale reviews from joanlopez, codebien, and mstoykov via 5389a22 June 6, 2024 12:32
@olegbespalov olegbespalov force-pushed the feat/stop-panic-catching branch from dcf4b54 to 5389a22 Compare June 6, 2024 12:32
@olegbespalov olegbespalov added the breaking change for PRs that need to be mentioned in the breaking changes section of the release notes label Jun 6, 2024
@olegbespalov
Copy link
Contributor Author

Have you checked if some extension doesn't use it - maybe we can tell them.

A quick search shows that only forks, but I'll check better later on 👍

mstoykov
mstoykov approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I did check through my https://github.com/mstoykov/xk6-extensions/tree/main/checkout-all-extensions as I was working around it either way - no usage were found.

@olegbespalov olegbespalov merged commit 75615bc into master Jun 6, 2024
23 checks passed
@olegbespalov olegbespalov deleted the feat/stop-panic-catching branch June 6, 2024 13:58
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebien codebien codebien approved these changes

@mstoykov mstoykov mstoykov approved these changes

@oleiade oleiade Awaiting requested review from oleiade oleiade is a code owner automatically assigned from grafana/k6-core

@joanlopez joanlopez Awaiting requested review from joanlopez

Assignees

@olegbespalov olegbespalov

Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes
Projects
None yet
Milestone
v0.52.0
Development

Successfully merging this pull request may close these issues.

Stop capturing panics and trying to continue execution after them.
5 participants
@olegbespalov @codecov-commenter @mstoykov @codebien @joanlopez